Add default task names for empty tasks #5071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
|
✅ No security or compliance issues detected. Reviewed everything up to 670085a. Security Overview
Detected Code Changes
Reply to this PR with |
- Handle edge case where tasks have no messages at all - Provide fallback names for tasks with empty/blank names - Ensure taskHistory entries are never blank, even after crashes - Add proper error handling for incomplete tasks Fixes cases where task history would show blank entries when: - Task crashes before first message is added - First message is malformed or empty - Task creation fails completely
…mpty messages case
- Add translation support to taskMetadata.ts using t() function
- Add 'incomplete' and 'no_messages' keys to all supported locales
- Replace hardcoded English strings with i18n keys:
- 'Task #{{taskNumber}} (Incomplete)' → 'common:tasks.incomplete'
- 'Task #{{taskNumber}} (No messages)' → 'common:tasks.no_messages'
- Translations added for all 16 supported languages:
ca, de, en, es, fr, hi, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW
- Verified complete translation coverage with missing translations script
Addresses internationalization of task history display names
- Add 'incomplete' and 'no_messages' keys to id/common.json - Complete translation coverage for all 17 supported languages - Verified with missing translations script
daniel-lxs
force-pushed
the
fix/disappearing-task-i18n
branch
from
cb08796 to
670085a
Compare
9 tasks
daniel-lxs
changed the title
mrubens
approved these changes
Jun 24, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
Co-authored-by: kiwina <[email protected]>
Alorse
pushed a commit
to Alorse/Roo-Code
that referenced
this pull request
Jun 27, 2025
Co-authored-by: kiwina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4410
This PR fixes disappearing task names in task history and internationalizes the fallback task names for better user experience across all supported languages.
Changes Made:
Bug Fixes
contextTokensfield to ensure type consistency withTokenUsageinterfaceCode Refactoring
taskMetadata()to use singlehistoryItemcreation instead of duplicating object creationhasMessagesflag and pre-calculated values for better code organizationlastRelevantMessagefallbackInternationalization
t()function from i18n module intaskMetadata.tstasks.incompleteandtasks.no_messagestocommon.jsonImpact:
Original by @kiwina